fix: user profile image upload issue

[wolgwang1729]

Description

• Fixes the profile image upload flow to prevent UI reversion and runtime edge-case failures after upload.
• Hardens form input handling for numeric fields by safely converting optional values to string using value?.toString() || "" in both profile form implementations.
• Improves uploader reliability by only setting loading state when files actually exist and by filtering out falsy upload results before invoking upload callbacks.
• Prevents accidental form submission during file upload by setting the uploader button to type="button".
• Replaces NextUI Input with native input for file selection to avoid controlled file input conflicts.
• Adds Blossom response normalization to support both top-level JSON fields and nip94_event.tags responses.
• Adds a fallback URL constructor from SHA-256 hash when URL is omitted by a Blossom server and throws a clear error if no usable URL can be resolved.
• Prevents stale context-driven profile resets in settings by guarding repeated form resets with if (contextLoadedRef.current) return;.

Screenshots (if applicable)

Previous Error:

After Fix:

Shopstr.Bitcoin-Native.Nostr.Marketplace.Shop.Freely.-.Google.Chrome.-.8.April.2026_blurred.mp4

Affirmation

• My code follows the CONTRIBUTING.md guidelines

[vercel]

@wolgwang1729 is attempting to deploy a commit to the shopstr-eng Team on Vercel.

A member of the Team first needs to authorize it.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the user profile image upload flow to prevent UI reversion and improve resilience across different Blossom server response formats.

Changes:

• Normalizes Blossom upload responses (top-level vs NIP-94 tags) and adds URL fallback construction from SHA-256 when needed.
• Hardens profile form numeric input stringification and prevents stale context-driven resets.
• Improves file uploader reliability (loading state, filtering upload results) and prevents accidental form submission during uploads.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
utils/nostr/nostr-helper-functions.ts	Normalizes Blossom responses and adds URL fallback + clearer error when URL can’t be resolved.
pages/settings/user-profile.tsx	Guards repeated form resets and hardens numeric input value conversion.
components/utility-components/file-uploader.tsx	Improves loading behavior, prevents accidental submit, and swaps to native file input.
components/settings/user-profile-form.tsx	Hardens numeric input value conversion.

Comments suppressed due to low confidence (1)

components/utility-components/file-uploader.tsx:1

• .filter((url) => Boolean(url)) doesn’t provide TypeScript narrowing (unlike a type-predicate), so the resulting array type may remain a union (e.g., (string | null)[]). If later code expects string[], prefer a type guard filter such as (url): url is string => typeof url === \"string\" && url.length > 0 (or at least url != null) to keep type safety.

import { useContext, useRef, useState } from "react";

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[GautamBytes]

can u solve the conflict?
ping me for review then

[GautamBytes]

pages/settings/user-profile.tsx still does DB-first hydration and writes back created_at: 0, and the new contextLoadedRef can block fresher profileContext updates after that. Please switch this page to the same timestamped recency/local-fallback logic as components/settings/user-profile-form.tsx so stale data can’t win after an image upload.

[wolgwang1729]

Great catch! I initially held off on changing the hydration approach in user-profile.tsx because it felt a bit outside the original scope of this PR, but I completely agree it's needed to prevent stale data from overriding the context.

I've now refactored both user-profile.tsx and user-profile-form.tsx to use the same timestamped local-fallback logic. The shared fallback functions are now in nostr-helper-functions.ts, so both files use a single source of truth for profile hydration.

[GautamBytes]

LGTM Now!!

Changes implemented.