Skip to content

Conversation

@nsaliu
Copy link
Contributor

@nsaliu nsaliu commented Jul 22, 2025

Closes #61

This PR wants to let the ShopURLIsNotReachableException extend Symfony\Component\HttpKernel\Exception\BadRequestHttpException.

@nsaliu nsaliu self-assigned this Jul 22, 2025
@nsaliu nsaliu changed the title refactor: extend ShopURLIsNotReachableException to use BadRequestHttpException and add status code refactor: ShopURLIsNotReachableException extends BadRequestHttpException Jul 22, 2025
@nsaliu nsaliu requested review from fschmtt and nam4am July 22, 2025 09:47
@nsaliu nsaliu requested a review from shyim July 22, 2025 12:59
@nsaliu nsaliu merged commit f420595 into main Jul 23, 2025
9 checks passed
@nsaliu nsaliu deleted the chore/return-400-status-code-then-the-shop-is-not-reachable branch July 23, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let the ShopURLIsNotReachableException extend BadRequestHttpException instead of RuntimeException

7 participants