Added Fastly secret to shop configuration #211
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances the Shopware Helm chart by adding support for Fastly CDN integration and usage data consent configuration. The changes enable users to optionally configure Fastly service references and API token references within the shop configuration, along with an explicit usage data consent field that defaults to "revoked".
- Added
usageDataConsentfield to shop configuration with default value "revoked" - Introduced optional
fastlyconfiguration block for Fastly CDN integration with serviceRef and tokenRef fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/shopware/values.yaml | Added commented example configuration showing the new usageDataConsent and fastly fields under shopConfiguration |
| charts/shopware/templates/store.yaml | Implemented template logic to render usageDataConsent with default value and conditional fastly configuration block |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/shopware/templates/store.yaml
Outdated
| shopConfiguration: | ||
| currency: {{ .Values.store.shopConfiguration.currency | default "EUR" }} | ||
| locale: {{ .Values.store.shopConfiguration.locale | default "en-GB" }} | ||
| usageDataConsent: {{ .Values.store.shopConfiguration.usageDataConsent | default "revoked" }} |
There was a problem hiding this comment.
we should change this to allowed because we want usageData from externals, but for us it must be revoked, so we should double check in our overlays
There was a problem hiding this comment.
shopware/shopware-operator#167
I also fixed the operator default values 😅
…or usageDataConsent
This pull request enhances the Shopware Helm chart by adding support for Fastly configuration and usage data consent within the
shopConfigurationsection. These changes allow for more flexible deployment configurations, particularly for environments using Fastly CDN and requiring explicit usage data consent settings.Shop configuration enhancements:
usageDataConsentfield toshopConfigurationin both thevalues.yamland thestore.yamltemplate, with a default value of"revoked"if not specified. [1] [2]fastlyconfiguration block undershopConfiguration, allowing users to specifyserviceRefandtokenReffor Fastly integration. This includeskeyandnamefields for both references. [1] [2]