feat: add the possibility to overwrite the cache with the operator #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrayserCassa
force-pushed
the
redis-overwrites
branch
from
958bda8 to
8a0c6ad
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to override Redis cache configuration using a DSN (Data Source Name) field instead of specifying individual connection parameters (host, port, index). This provides more flexibility for users who have pre-configured Redis DSN strings.
Key Changes:
- Added
RedisDsnfield toRedisSpecstruct for specifying Redis connection as a complete DSN string - Updated cache configuration logic to prioritize DSN when provided, falling back to individual fields otherwise
- Applied DSN support consistently across AppCache, SessionCache, and Worker configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| api/v1/store.go | Adds RedisDsn field to RedisSpec struct to support DSN-based Redis configuration |
| api/v1/store_env.go | Updates getAppCache(), getSessionCache(), and getWorker() to use DSN when provided, otherwise build from individual fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TrayserCassa
force-pushed
the
redis-overwrites
branch
from
8a0c6ad to
f0dba3d
Compare
TrayserCassa
force-pushed
the
redis-overwrites
branch
from
f0dba3d to
18ee739
Compare
TrayserCassa
force-pushed
the
redis-overwrites
branch
from
18ee739 to
995c531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.