Jira Bridge Improvements #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e latest introduces some changes that break the existing code
pscadding
reviewed
Mar 18, 2025
Comment on lines
+209
to
+216
| self.assertFalse( | ||
| bridge.sync_in_jira( | ||
| self.HANDLER_NAME, | ||
| "Shot", | ||
| mock_shotgun.SG_SHOT["id"], | ||
| mock_shotgun.SG_SHOT_CHANGE_EVENT, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is it also worth checking that we log a message? Is that possible?
That way we can be more confident that the reason it has come back false is for the reason we think it is. Otherwise, the test might pass but for an entirely different reason that caused the sync to be false.
pscadding
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some improvements to the Jira Bridge by creating a new handler with the following specificities: