SG-38210 Add RV Live Review metrics #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good. However, this will require an update also on SG web as well.
PS: To pass CI you can rebase #1010
OK thank you @carlos-villavicencio-adsk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SG-38210 Add RV Live Review metrics
This commit adds RV Live Review events to the allowlist in metrics.py
Context:
Note that prior to the RV 2024 release which was based off OpenRV as a submodule, RV had its own Amplitude secret to report Amplitude events. Since that we did not want to make this secret public when we open sourced RV, this secret was removed and we lost the capability of reporting Amplitude analytics events in RV.
That being said, the RV Code was only reporting Live Review related events.
This commit restores this functionality in RV.
This is just a proposal, please feel free to refuse this PR or ask me to rework it.
Thanks