bug fixes #17
Open
bug fixes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiiigh
force-pushed
the
master
branch
5 times, most recently
from
e431936 to
a5cb93f
Compare
|
I squashed all the commits into one |
fixed the problems change new Buffer() to Buffer.alloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey this pull request includes:
Making Connection a Duplex Stream instead of an EventEmitter
Fixing the problem with getting corrupted data
CurrentNode of the LinkedList will point to the node with the lowest value, not the first node added
-- Imagine adding numbers in this order into the list: 9, 1, 5, 3, 4, 5, 8. The currentNode in the current implementation would be 9 and if you use the seek() function you would always get 9 because there is no node after 9 since it is the largest and also making current node to point to the node with the lowest value makes more sense
Sending the ACK for packets that have sequence number lower than what we expected again.