Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #416

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Code cleanup #416

merged 8 commits into from
Feb 14, 2025

Conversation

DaleStan
Copy link
Collaborator

I just upgraded to VS 17.13, and it has more code-style opinions than 17.12 did.

VS wants to fix IDE0306 by generating invalid code, but I went ahead and applied most of the rest.

@DaleStan DaleStan requested a review from veger February 14, 2025 16:54
@DaleStan DaleStan requested a review from shpaass as a code owner February 14, 2025 16:54
@shpaass
Copy link
Owner

shpaass commented Feb 14, 2025

VS wants to fix IDE0306 by generating invalid code, but I went ahead and applied most of the rest.

Quoting my chat with a Visual Studio guy:

All fixers can change code meaning. (Not joking)

Saying it to prevent the case of applying an inspection without looking through the results.

Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup!

@shpaass shpaass merged commit 9b57fdb into shpaass:master Feb 14, 2025
1 check passed
@DaleStan DaleStan deleted the code-cleanup branch February 15, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants