Qt6 port rebased and split up #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is used for Qt4, Qt5 and Qt6 compatibility. Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
Signed-off-by: Andreas Sturmlechner <[email protected]>
|
Folks, thanks for your efforts; really appreciated. But there are some problems that I summarized in #280, most notably the need for a new logger. |
Open
|
I don't see a blocker, honestly. Porting to Qt6 does not impede your wish to implement a new logger. Certainly, these split up commits would enable you to cherry-pick easily what you perceive as useful. That would at least reduce the patch delta for our downstream maintainer, should they decide to keep qdirstat in our repository by means of applying such a Qt6 port patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept @gamecreature's (let me know what you think!) good work with full attribution, but changed the approach for endl, SkipEmptyparts and KeepEmptyParts.
Built fine with Qt-5.15.16 and Qt-6.8.2. As Qt4 is completely unbuildable on a modern system, I can't test that.
See also:
[1] #194
[2] #242