chore: bump salvo #121
Merged
chore: bump salvo #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
force-pushed
the
chore/bump-salvo
branch
from
aa09915 to
287ccc8
Compare
oddgrd
added
the
Awaiting Release
oddgrd
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I had to make some changes since this was created against the develop branch, but this LGTM, thanks!
PS. do we document anywhere that the develop branch should be used? I can't find it. 😅
Edit: we document using the develop branch in the PR templates, I will remove it, apologies for the confusion!
oddgrd
added a commit
that referenced
this pull request
Jan 9, 2024
Co-authored-by: oddgrd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Upgrades salvo version for its example. Should only be merged after shuttle#1486 is released. Keeping this as draft because if merged right now, it will break the example.
Once the shuttle-salvo is upgraded, this test may break after the shuttle version bump
How has this been tested? (if applicable)
Local tested only as it's not possible to deploy with current Salvo version