Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update axum examples to axum 0.7 #123

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jan 3, 2024

Description of change

How has this been tested? (if applicable)

Checked the ones with bigger changes locally. CI will fail unless we change the workflow to checkout the main branch of the main repo, which might not be desired on a main branch. (an argument for using main+develop) 🤷‍♂️

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you tested it locally it's fine. Even with a develop branch, CI will fail until we release the new crates, no?

@jonaro00
Copy link
Member Author

jonaro00 commented Jan 4, 2024

My thought there is that the develop branch would check out the main repo and apply patches, while main branch does it like now.
I can run the CI locally for all axum projects just to be sure.

@jonaro00
Copy link
Member Author

jonaro00 commented Jan 4, 2024

There was some more to do. Should be good now. Edit: Now it's all done

@oddgrd oddgrd changed the base branch from main to develop January 8, 2024 17:47
@oddgrd oddgrd merged commit 9439967 into shuttle-hq:develop Jan 8, 2024
0 of 2 checks passed
oddgrd pushed a commit that referenced this pull request Jan 9, 2024
@jonaro00 jonaro00 deleted the axum-0-7 branch January 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants