-
Notifications
You must be signed in to change notification settings - Fork 48
fix: fixed docs to run image-factory properly #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| -v $PWD/signing-key.key:/signing-key.key:ro \ | ||
| -v $PWD/cosign.pub:/cosign.pub:ro \ | ||
| ghcr.io/siderolabs/image-factory \ | ||
| ghcr.io/siderolabs/image-factory:v0.9.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably add this to the snippets/custom-variables.mdx so it's easier to change in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this right now is that the way you can configure Image Factory has been change from v0.9.0-3. Version v0.9.0-2 still uses the old config method.
When there will be a new release we have to rewrite the docs once more or use some sort of method like we're using with the Talos docs.
| ``` | ||
|
|
||
| ### Image Cache Signing Key | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this has its own header let's add a sentence about what this is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this:
You need to create a Cache Signing Key to sign cached Talos image artifacts, ensuring they haven’t been tampered with before being served.
|
/m |
Signed-off-by: Kevin Tijssen <[email protected]>
Signed-off-by: Kevin Tijssen <[email protected]>
Signed-off-by: Kevin Tijssen <[email protected]>
f5418e6 to
54403cf
Compare
|
/m |
I have changed the docs to make sure people run in image-factory properly.