fix: ensure proper closure of client.Client.conn with finalizer

Always close the connection, even if we forgot to do this ourselves.

Signed-off-by: Dmitriy Matrenichev <[email protected]>

pkg/machinery/client/client.go

@@ -13,6 +13,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"runtime"
 	"time"
 
 	cosiv1alpha1 "github.com/cosi-project/runtime/api/v1alpha1"
@@ -173,11 +174,16 @@ func New(_ context.Context, opts ...OptionFunc) (c *Client, err error) {
 	c.Inspect = &InspectClient{c.InspectClient}
 	c.COSI = state.WrapCore(client.NewAdapter(cosiv1alpha1.NewStateClient(c.conn)))
 
+	// Just like Go team does in their os.File internals, lets ensure that we always close the connection.
+	runtime.SetFinalizer(c.conn, (*grpcConnectionWrapper).Close)
+
 	return c, nil
 }
 
 // Close shuts down client protocol.
 func (c *Client) Close() error {
+	runtime.SetFinalizer(c.conn, nil) // remove so it doesn't get closed twice
+
 	return c.conn.Close()
 }