Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "bignumber is not a constructor" in electron env #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/parse.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ var json_parse = function (options) {
if (!isFinite(number)) {
error('Bad number');
} else {
if (BigNumber == null) BigNumber = require('bignumber.js');
if (BigNumber == null) BigNumber = require('bignumber.js').BigNumber;
//if (number > 9007199254740992 || number < -9007199254740992)
// Bignumber has stricter check: everything with length > 15 digits disallowed
if (string.length > 15)
Expand Down
7 changes: 6 additions & 1 deletion lib/stringify.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var BigNumber = require('bignumber.js');
var BigNumber = require('bignumber.js').BigNumber;

/*
json2.js
Expand Down Expand Up @@ -217,6 +217,11 @@ var JSON = module.exports;
value = holder[key],
isBigNumber = value != null && (value instanceof BigNumber || BigNumber.isBigNumber(value));

// return big int to raw instead of scientific counting such as 1.11e8
if (value instanceof BigNumber) {
return value.toFixed();
}

// If the value has a toJSON method, call it to obtain a replacement value.

if (value && typeof value === 'object' &&
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "json-bigint",
"name": "@qii404/json-bigint",
"version": "1.0.0",
"description": "JSON.parse with bigints support",
"description": "JSON.parse with bigints support, forked from sidorares/json-bigint by qii404",
"main": "index.js",
"files": [
"index.js",
Expand All @@ -13,7 +13,7 @@
},
"repository": {
"type": "git",
"url": "[email protected]:sidorares/json-bigint.git"
"url": "[email protected]:qishibo/json-bigint.git"
},
"keywords": [
"JSON",
Expand Down
4 changes: 2 additions & 2 deletions test/bigint-parse-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var mocha = require('mocha')
, assert = require('chai').assert
, expect = require('chai').expect
, BigNumber = require('bignumber.js')
, BigNumber = require('bignumber.js').BigNumber
;

describe("Testing native BigInt support: parse", function () {
Expand Down Expand Up @@ -56,4 +56,4 @@ describe("Testing native BigInt support: parse", function () {
expect(output).to.equal(input);
done();
});
});
});
4 changes: 2 additions & 2 deletions test/bigint-stringify-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var mocha = require('mocha')
, assert = require('chai').assert
, expect = require('chai').expect
, BigNumber = require('bignumber.js')
, BigNumber = require('bignumber.js').BigNumber
;

describe("Testing native BigInt support: stringify", function () {
Expand Down Expand Up @@ -33,4 +33,4 @@ describe("Testing native BigInt support: stringify", function () {
);
done();
});
});
});
2 changes: 1 addition & 1 deletion test/bigint-test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var mocha = require('mocha')
, assert = require('chai').assert
, expect = require('chai').expect
, BigNumber = require('bignumber.js')
, BigNumber = require('bignumber.js').BigNumber
;

describe("Testing bigint support", function(){
Expand Down