Skip to content

chore(v1.2.2): pin ws to 8.x, remove webpack analyser and improve wsOptions type #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiagosiebler merged 1 commit into from
Jul 17, 2026
Merged

chore(v1.2.2): pin ws to 8.x, remove webpack analyser and improve wsOptions type #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 12 additions & 111 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "coinbase-api",
"version": "1.2.1",
"version": "1.2.2",
"description": "Node.js SDK for Coinbase's Advanced Trade, App, Exchange, International, Prime & Commerce REST APIs and WebSockets, with TypeScript & strong end to end tests.",
"scripts": {
"clean": "rm -rf dist",
Expand Down Expand Up @@ -33,16 +33,16 @@
"Jerko J (https://github.com/JJ-Cro)"
],
"dependencies": {
"@types/ws": "^8.18.1",
"axios": "^1.13.2",
"isomorphic-ws": "^4.0.1",
"jose": "^6.1.3",
"nanoid": "^3.3.11",
"ws": "^7.4.0"
"ws": "8.21.1"
},
"devDependencies": {
"@types/jest": "^29.5.12",
"@types/node": "^22.10.2",
"@types/ws": "^8.5.10",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
"eslint": "^8.29.0",
Expand All @@ -56,7 +56,6 @@
"ts-node": "^10.9.2",
"typescript": "^5.7.3",
"webpack": "^5.0.0",
"webpack-bundle-analyzer": "^5.1.1",
"webpack-cli": "^4.0.0"
},
"keywords": [
Expand Down
5 changes: 4 additions & 1 deletion src/types/websockets/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ export interface WSClientConfigurableOptions {
wsOptions?: {
protocols?: string[];
agent?: any;
} & Partial<WebSocket.ClientOptions | ClientRequestArgs>;
} & (
| Omit<Partial<WebSocket.ClientOptions>, 'agent'>
| Omit<Partial<ClientRequestArgs>, 'agent'>
);

/**
* Connect to the sandbox for supported products
Expand Down
11 changes: 0 additions & 11 deletions webpack/webpack.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
const path = require('path');
const BundleAnalyzerPlugin =
require('webpack-bundle-analyzer').BundleAnalyzerPlugin;

function generateConfig(name) {
var config = {
Expand Down Expand Up @@ -34,15 +32,6 @@ function generateConfig(name) {
},
};

config.plugins = [
new BundleAnalyzerPlugin({
defaultSizes: 'stat',
analyzerMode: 'static',
reportFilename: '../doc/bundleReport.html',
openAnalyzer: false,
}),
];

return config;
}

Expand Down