Skip to content

DONT MERGE: chore(datatable): reproduce issue on playground #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chintankavathia wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DONT MERGE: chore(datatable): reproduce issue on playground #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions src/app/examples/si-accordion/si-accordion-tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
<si-tabset>
<si-tab heading="Tab 1" [active]="true">Hello</si-tab>
<si-tab heading="Tab 2 with table">
<div class="bg-base-0 p-5">
<h4>On base-0</h4>
<si-accordion>
<si-collapsible-panel
heading="Hey there"
(panelToggle)="logEvent('toggle Hey there', $event)"
>
<div class="p-6"> Here is some content </div>
</si-collapsible-panel>
<si-collapsible-panel
heading="Another one"
badge="5"
badgeColor="info"
contentCssClasses="p-6"
(panelToggle)="logEvent('toggle Another one', $event)"
>
<si-search-bar colorVariant="base-0" placeholder="Search..." />
<ngx-datatable
class="table-element"
columnMode="force"
[rows]="[
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 }
]"
[columns]="[{ prop: 'name' }, { prop: 'age' }]"
Comment on lines +24 to +38
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and separation of concerns, it's recommended to move the hardcoded data for the ngx-datatable from the template to the component's TypeScript file. This makes the template cleaner and the data easier to manage.

You can define the data in your SampleComponent class:

export class SampleComponent {
  // ...
  logEvent = inject(LOG_EVENT);

  tableRows = [
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 },
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 },
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 },
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 },
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 },
    { name: 'John', age: 30 },
    { name: 'Jane', age: 25 }
  ];

  tableColumns = [{ prop: 'name' }, { prop: 'age' }];
}

Then use these properties in the template.

Suggested change
[rows]="[
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 },
{ name: 'John', age: 30 },
{ name: 'Jane', age: 25 }
]"
[columns]="[{ prop: 'name' }, { prop: 'age' }]"
[rows]="tableRows"
[columns]="tableColumns"

/>
</si-collapsible-panel>
<si-collapsible-panel
heading="Number three"
contentCssClasses="p-6"
(panelToggle)="logEvent('toggle Number three', $event)"
>
Nothing to see here
</si-collapsible-panel>
<si-collapsible-panel
contentCssClasses="p-6"
(panelToggle)="logEvent('toggle Number four', $event)"
>
<span si-panel-heading>Heading via content projection</span>
Nothing to see here
</si-collapsible-panel>
</si-accordion>
</div>
</si-tab>
</si-tabset>
27 changes: 27 additions & 0 deletions src/app/examples/si-accordion/si-accordion-tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**
* Copyright (c) Siemens 2016 - 2026
* SPDX-License-Identifier: MIT
*/
import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { SiAccordionComponent, SiCollapsiblePanelComponent } from '@siemens/element-ng/accordion';
import { SiSearchBarComponent } from '@siemens/element-ng/search-bar';
import { SiTabComponent, SiTabsetComponent } from '@siemens/element-ng/tabs';
import { LOG_EVENT } from '@siemens/live-preview';
import { DatatableComponent } from '@siemens/ngx-datatable';

@Component({
selector: 'app-sample',
imports: [
SiAccordionComponent,
SiCollapsiblePanelComponent,
DatatableComponent,
SiTabComponent,
SiTabsetComponent,
SiSearchBarComponent
],
templateUrl: './si-accordion-tabs.html',
changeDetection: ChangeDetectionStrategy.OnPush
})
export class SampleComponent {
logEvent = inject(LOG_EVENT);
}
Loading