fix(launchpad): align external icon size and spacing with design specs#1546
Open
fix(launchpad): align external icon size and spacing with design specs#1546
Conversation
ljanner
force-pushed
the
fix/launchpad-icon-external-size
branch
2 times, most recently
from
cde4a74 to
8a2b9f2
Compare
ljanner
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix the size of the external icon in the launchpad. The change removes the explicit font-size for the external icon, allowing it to inherit size from its parent text container, which is a good improvement for consistency. However, the change also removes the explicit font-size for the favorite icon. My review includes a comment pointing out that this could lead to inconsistent rendering for the favorite icon, as its size will now be implicit. I've suggested restoring an explicit size for it, using a theme variable.
projects/element-ng/application-header/launchpad/si-launchpad-app.component.scss
Show resolved
Hide resolved
|
Documentation. Coverage Reports: |
ljanner
force-pushed
the
fix/launchpad-icon-external-size
branch
from
8a2b9f2 to
5efaacb
Compare
ljanner
changed the title
ljanner
force-pushed
the
fix/launchpad-icon-external-size
branch
from
5efaacb to
98a5753
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed wrong spacing and sizing of external icon.
Additionally simplified favourite icon css to properly match design specs.