Conversation
spike-rabbit
commented
Feb 19, 2026
spike-rabbit
commented
- I confirm that this MR follows the contribution guidelines.
Running `chmod u+x` on the shell files.
Interpolating GitHub Actions variables in shell script does not work.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue in the release script where the check for the default branch was not working correctly. By passing the information as a script argument, the logic is now correct and more robust. I have one suggestion to further improve the robustness of this check by making it case-insensitive.
| DEPLOY_LATEST="false" | ||
|
|
||
| if [[ "${{ github.ref_name }}" == "${{ github.event.repository.default_branch }}" ]]; then | ||
| if [[ "$IS_DEFAULT_BRANCH" == "true" ]]; then |
There was a problem hiding this comment.
The string comparison to check if this is the default branch is case-sensitive. To make the script more robust against potential variations in the input (e.g., True or TRUE), consider converting the variable to lowercase before the comparison. This will prevent unexpected behavior if the value passed from the CI workflow changes. Note that the ${VAR,,} syntax for case conversion requires bash version 4 or newer, which is available on GitHub-hosted runners.
| if [[ "$IS_DEFAULT_BRANCH" == "true" ]]; then | |
| if [[ "${IS_DEFAULT_BRANCH,,}" == "true" ]]; then |
1 participant
