Skip to content

Conversation

ian-sift
Copy link
Contributor

@ian-sift ian-sift commented Aug 7, 2025

Verification

Ailin's benchmarking https://siftstack.atlassian.net/wiki/spaces/sift/pages/1071874168/SiftStreamPy+Benchmarking

Ran her branch and discovered channels weren't being tagged to runs so included fixes to that in my update to her ingestion thread logic she requested. Running our various ingestion examples works as expected.

She re-ran post my changes and saw results consistent w/ initial benchmarking

@ian-sift ian-sift requested a review from alexluck-sift August 7, 2025 21:49
@ian-sift ian-sift requested review from niliayu and removed request for alexluck-sift August 18, 2025 18:21
Copy link

@niliayu niliayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me now! Want to make sure @marc-sift is aligned too, and otherwise my questions are more around next steps. Do we want to merge this to main right now and cut the release candidate from main, or merge to a release candidate branch and then merge that branch into main once we're ready to full release? I think the tradeoff with the second option is less time pressure for getting the changes tested, but potential for merge conflict messiness.

@ian-sift ian-sift closed this Aug 18, 2025
@ian-sift ian-sift reopened this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants