-
Notifications
You must be signed in to change notification settings - Fork 4
Python(feat): Use sift_stream_bindings under the hood for ingestion #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e an additional RunForm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me now! Want to make sure @marc-sift is aligned too, and otherwise my questions are more around next steps. Do we want to merge this to main right now and cut the release candidate from main, or merge to a release candidate branch and then merge that branch into main once we're ready to full release? I think the tradeoff with the second option is less time pressure for getting the changes tested, but potential for merge conflict messiness.
Verification
Ailin's benchmarking https://siftstack.atlassian.net/wiki/spaces/sift/pages/1071874168/SiftStreamPy+Benchmarking
Ran her branch and discovered channels weren't being tagged to runs so included fixes to that in my update to her ingestion thread logic she requested. Running our various ingestion examples works as expected.
She re-ran post my changes and saw results consistent w/ initial benchmarking