-
Notifications
You must be signed in to change notification settings - Fork 4
python(feat): client consistency #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-sift
reviewed
Sep 11, 2025
ian-sift
requested changes
Sep 12, 2025
dd08759
to
5e07bed
Compare
ian-sift
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some tests failed. Also, can you post verif evidence? like do the tests still work?
This PR is in draft pending some proto updates for completion. |
b7e99c5
to
edc3e8d
Compare
added `proto` field to BaseType so that the original is accessible
edc3e8d
to
e2feb35
Compare
ian-sift
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing Guidelines
MappingHelper
Low-Level Wrappers
Update to use latest protos.
CEL Utils
timestamp()
Resources
list_
methods to use consistent argument ordering and naming between resourcesSift Types
proto
field to store the returned Proto for user inspection if desired (catchall for if we don't update the Pydantic model or expose all fields that are exposed in the grpc message)ModeUpdate
pydantic model into aModelCreateUpdateBase
andModelCreate
andModelUpdate
to separate concerns and share common functionality.ChannelConfig
to separate concerns between a SiftChannel
and the ingestion definition for a channelMisc
dict()
as way of instantiating dictionariesgriffe-pydantic
for improved docs rendering of Pydantic models