Skip to content

Conversation

alexluck-sift
Copy link
Collaborator

@alexluck-sift alexluck-sift commented Sep 11, 2025

Contributing Guidelines

  • New section on pydantic create/update model and inheritance
  • Explanation on proto MappingHelper
  • New section on Resource Method Patterns for ordering of function arguments and helper methods

Low-Level Wrappers
Update to use latest protos.

CEL Utils

  • Fix timestamp handling by wrapping in timestamp()
  • Add support for duartion
  • Fix equals boolean to convert to lowercase bool string

Resources

  • Added new common CEL filter builders for common resource filter arguments
  • Cleaned up list_ methods to use consistent argument ordering and naming between resources
  • Update create/update/archive/unarchive to be consistent across resources

Sift Types

  • Added proto field to store the returned Proto for user inspection if desired (catchall for if we don't update the Pydantic model or expose all fields that are exposed in the grpc message)
  • Broke out the ModeUpdate pydantic model into a ModelCreateUpdateBase and ModelCreate and ModelUpdate to separate concerns and share common functionality.
  • Updated model fields to accurately reflect proto fields required/optional state
  • created a new ChannelConfig to separate concerns between a Sift Channel and the ingestion definition for a channel

Misc

  • Added exception for Ruff rule C408 to allow for dict() as way of instantiating dictionaries
  • Added griffe-pydantic for improved docs rendering of Pydantic models

@alexluck-sift alexluck-sift force-pushed the python/feat/sift-client-consistency branch from dd08759 to 5e07bed Compare September 15, 2025 20:58
Copy link
Contributor

@ian-sift ian-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some tests failed. Also, can you post verif evidence? like do the tests still work?

@alexluck-sift
Copy link
Collaborator Author

looks like some tests failed. Also, can you post verif evidence? like do the tests still work?

This PR is in draft pending some proto updates for completion.

@alexluck-sift alexluck-sift changed the title Python/feat/sift client consistency python(feat): client consistency Sep 29, 2025
@alexluck-sift alexluck-sift force-pushed the python/feat/sift-client-consistency branch 2 times, most recently from b7e99c5 to edc3e8d Compare October 6, 2025 21:28
@alexluck-sift alexluck-sift force-pushed the python/feat/sift-client-consistency branch from edc3e8d to e2feb35 Compare October 7, 2025 01:39
@alexluck-sift alexluck-sift requested a review from ian-sift October 7, 2025 02:05
@alexluck-sift alexluck-sift marked this pull request as ready for review October 7, 2025 02:05
@alexluck-sift alexluck-sift marked this pull request as draft October 7, 2025 02:06
@alexluck-sift alexluck-sift marked this pull request as ready for review October 8, 2025 00:38
@alexluck-sift alexluck-sift merged commit cb2c9c1 into main Oct 8, 2025
10 checks passed
@alexluck-sift alexluck-sift deleted the python/feat/sift-client-consistency branch October 8, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants