test: MPC + stream component test (part 1)#757
Draft
jakmeier wants to merge 9 commits intosig-net:developfrom
Draft
test: MPC + stream component test (part 1)#757jakmeier wants to merge 9 commits intosig-net:developfrom
jakmeier wants to merge 9 commits intosig-net:developfrom
Conversation
Create a MockStream that connects to the MPC fixture setup. This lets us test the indexer stream <-> MPC glue.
but not with channel capacity?
otherwise it is always the same participant in round 0
adding useful cases and checking if they run in ci
Instead of starting eagerly, give all deliberators some time to response with accept. This avoids that with every signature, N-threshold nodes fall into the bad state where they keep trying to form a new posit round, even when they could have been included in the first round.
b26e7fd to
2a87771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a MockStream that connects to the MPC fixture
setup. This lets us test the indexer stream <-> MPC glue.
This is part 1, with just the tests adjusted to pass with the current configuration.
See #739 for tests that show current issues that need fixing.