Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
This PR adds two arguments passed on Application Under Test launch:
-AppleLocale en_US
and-AppleLanguages (en)
This sets application locale to
en_US
in order to successfully runSignalUITests
andSignalServiceKitTests
on a Mac with locale set other thanen_US
(for example:en_GB
).Otherwise when running on non-en_US locale some tests fail with following error:
XCTAssertEqual failed: ("["+445215550100", "+5215550100", "+15215550100"]") is not equal to ("["+15215550100", "+5215550100"]") - searchText: 5215550100
Tests fail due to wrong phone prefix
+44
instead of+1
With setting locale to
en_US
and language toen
tests succeed.