Skip to content

Fix locale for UI tests #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fr0l
Copy link

@fr0l fr0l commented May 12, 2025

First time contributor checklist

Contributor checklist

  • [ x] My commits are rebased on the latest main branch
  • [ x] My commits are in nice logical chunks
  • [ x] My contribution is fully baked and is ready to be merged as is
  • [ x] I have tested my contribution on these devices:
  • iDevice A, iOS X.Y.Z
  • iDevice B, iOS Z.Y

Description

This PR adds two arguments passed on Application Under Test launch: -AppleLocale en_US and -AppleLanguages (en)

This sets application locale to en_US in order to successfully run SignalUITests and SignalServiceKitTests on a Mac with locale set other than en_US (for example: en_GB).

Screenshot 2025-05-12 at 12 44 09

Otherwise when running on non-en_US locale some tests fail with following error:

XCTAssertEqual failed: ("["+445215550100", "+5215550100", "+15215550100"]") is not equal to ("["+15215550100", "+5215550100"]") - searchText: 5215550100

Tests fail due to wrong phone prefix +44 instead of +1

With setting locale to en_US and language to en tests succeed.

@fr0l fr0l force-pushed the FixLocaleForUITests branch from 800668f to e84e3d6 Compare May 21, 2025 09:09
@fr0l fr0l force-pushed the FixLocaleForUITests branch from 831b4fc to b7e359f Compare May 27, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant