Skip to content

[Windows] Fix calculating credential blob size #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hawkeye116477 wants to merge 1 commit into from
Closed

[Windows] Fix calculating credential blob size #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SIL.PasswordStore/Provider/WindowsProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ public void SetPassword(string service, string user, string password)

var passwordLength = string.IsNullOrEmpty(password)
? 0
: (uint)Encoding.UTF8.GetBytes(password).Length + 1;
: (uint)Encoding.Unicode.GetByteCount(password);
var credential = new Credential {
Flags = 0,
Type = CredType.Generic,
TargetName = GetTargetName(service, user),
Comment = null,
CredentialBlobSize = passwordLength * 2,
CredentialBlobSize = passwordLength,
CredentialBlob = Marshal.StringToCoTaskMemUni(password),
Persist = CredPersist.LocalMachine,
AttributeCount = 0
Expand Down