Fix 404 on HEAD for the FW Lite App Installer manifest - #2596
Merged
Conversation
Windows App Installer probes the .appinstaller URL with HEAD and requires Content-Length; [HttpGet] alone 405s that request. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hahn-kev
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when windows tries to autoupdate from an AppInstaller it calls HEAD on the url, this currently fails with a 404. This fixes that.
AI summary
Windows App Installer sends a HEAD request to the
.appinstallermanifest URL and requires aContent-Lengthheader. ASP.NET Core routing does not match HEAD against an[HttpGet]-only action, so the router returned 405.This adds
[HttpHead]on the sameAppInstalleraction. No separate handler:File()already setsContent-LengthandContent-Typeand omits the body for HEAD. Other fwlite-release endpoints are JSON or redirects and are not probed by App Installer.Test plan
AppInstallerActionAcceptsHeadOnTheSamePathAsGetpassescurl -I https://<host>/api/fwlite-release/FieldWorksLite.appinstallerreturns 200 withContent-LengthandContent-Type: application/appinstallerMade with Cursor