Add Svelte error-boundary guards for LexBox page throws - #2602
Open
hahn-kev-bot wants to merge 1 commit into
Open
Add Svelte error-boundary guards for LexBox page throws#2602hahn-kev-bot wants to merge 1 commit into
hahn-kev-bot wants to merge 1 commit into
Conversation
Wrap layout children in <svelte:boundary> with retry/go-home recovery so a render throw no longer takes down the whole tree.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we now catch render errors in the UI so users don't get stuck without knowing what's going on.
AI summary
LexBox SvelteKit now wraps layout children in Svelte 5
<svelte:boundary>so a page render throw can recover in place instead of taking down the whole tree.ErrorBoundarytraces withapp.error.source: svelte-boundaryand never resets fromonerrorErrorRecoveryshowserrors.apology, the error message, Retry, and Go home (rel="external"for a full document load){@render children?.()}(footer, overlay,UnexpectedErrorAlertstay outside)<Layout>so AppBar survivessandbox okerrors.retryadded in en/es/fr/ko+error.svelteandUnexpectedErrorAlertare unchanged.Test plan
pnpm checkinfrontend/(0 errors)/sandbox, click Throw render errorsandbox render error, Retry, and Go homesandbox okrel="external"); unauthenticated users land on/loginUnexpectedErrorAlert(unchanged)