SF-3565 Fix error when opening a note in a Lynx insight #3473
+16
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition on editor load where in some circumstances Lynx insights were inserted before the notes were added, resulting in an inability for notes to be reformatted (i.e. the removing of the highlight state) when they were enclosed by a lynx insight.
As notes are embed blots, not inline or block blots, they should not contain an inline blot. However, as the note thread may still end up being wrapped by a lynx insight's inline embed if a note is inserted within its bounds either by sync or user action, I implemented a default
appendChild
function for the note thread embed blot, which will quietly drop the event (as the embed blot cannot render an inline blot inside it anyway).This change is