-
Notifications
You must be signed in to change notification settings - Fork 0
11 mig web widget x2many 2d matrix #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincent-hatakeyama
wants to merge
456
commits into
simahawk:11-mig-web_widget_x2many_2d_matrix
Choose a base branch
from
xcgd:11-mig-web_widget_x2many_2d_matrix
base: 11-mig-web_widget_x2many_2d_matrix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
11 mig web widget x2many 2d matrix #1
vincent-hatakeyama
wants to merge
456
commits into
simahawk:11-mig-web_widget_x2many_2d_matrix
from
xcgd:11-mig-web_widget_x2many_2d_matrix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef5937c
to
0628b00
Compare
Codecov Report
@@ Coverage Diff @@
## 11-mig-web_widget_x2many_2d_matrix #1 +/- ##
======================================================================
+ Coverage 75.67% 83.33% +7.65%
======================================================================
Files 3 10 +7
Lines 37 114 +77
======================================================================
+ Hits 28 95 +67
- Misses 9 19 +10
Continue to review full report at Codecov.
|
Currently translated at 66.7% (6 of 9 strings) Translation: web-11.0/web-11.0-web_responsive Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_responsive/pt_BR/
[IMP][11.0][web_responsive] Sticky Statusbar & List View Header-Footer
[FIX][11.0][web_responsive] Views without sheet
* Fixes issue OCA#987 * Follow new readme structure * Use Less * Hide expand/collapse buttons if select a view type that isn't a 'list'
If we honor the domain value, the user may not be getting all available records when selecting from an x2many dropdown, or even worse, if the domain references another field in the view, the user may be getting an error when opening the field dropdown, like this: Error: NameError: name 'company_id' is not defined http://localhost/web/static/lib/py.js/lib/py.js:370 Rastreo de error: PY_ensurepy@http://localhost/web/static/lib/py.js/lib/py.js:370:19 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1340:20 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1397:35 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1409:34 py.eval@http://localhost/web/static/lib/py.js/lib/py.js:1453:16 eval_domains/<@http://localhost/web/static/src/js/core/pyeval.js:886:39 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9 _.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29 eval_domains@http://localhost/web/static/src/js/core/pyeval.js:877:16 pyeval@http://localhost/web/static/src/js/core/pyeval.js:988:16 stringToArray@http://localhost/web/static/src/js/core/domain.js:243:16 _getDomain@http://localhost/web/static/src/js/views/basic/basic_model.js:3004:24 _search@http://localhost/web_m2x_options/static/src/js/form.js:139:26 source@http://localhost/web/static/src/js/fields/relational_fields.js:198:17 _search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6823:3 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6815:10 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 $.widget.bridge/$.fn[name]/<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:508:19 each@http://localhost/web/static/lib/jquery/jquery.js:383:49 each@http://localhost/web/static/lib/jquery/jquery.js:136:24 $.widget.bridge/$.fn[name]@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:494:4 _onInputClick@http://localhost/web/static/src/js/fields/relational_fields.js:565:13 proxy/<@http://localhost/web/static/src/js/core/mixins.js:279:20 dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50 add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41
…ix_x2many [FIX] web_advanced_search: Ignore field domain
When user was replacing some specific sections or being too fast, the module wasn't behaving fine. Also, it was always displaying the original `.` slightly before doing the replacement.
The method `_onOpenColorPicker` is defined on `FormFieldMany2ManyTags`, not in `FieldMany2ManyTags`, so it can only be called on its descendants. Otherwise, clicking on a `many2many_tags` tag when found in a tree view produces an error such as: TypeError: self._onOpenColorPicker is not a function http://localhost/web_m2x_options/static/src/js/form.js:354 Rastreo de error: _onOpenBadge@http://localhost/web_m2x_options/static/src/js/form.js:354:17 proxy/<@http://localhost/web/static/src/js/core/mixins.js:279:20 dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50 add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41
…t-fix_race [FIX] web_decimal_numpad_dot: Fix inconsistent behavior
…2m_tags_list_view [FIX] web_m2x_options: Fix error in tree views with many2many_tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
When OCA#1154 switched to using `keydown` as the event to trigger the numpad dot replacement, it was actually [disabling upstream's `_onKeyDown()`][1], which in turn disabled the keyboard navigation. To fix this situation, I replaced the method that is being used to directly override `_onKeyDown`. [1]: https://github.com/odoo/odoo/blob/19558129f0e2d5c9940f6fa95534840f8f025547/addons/web/static/src/js/fields/abstract_field.js#L41
…t-fix_keyboard_navigation [FIX] web_decimal_numpad_dot: Restore keyboard navigation
…ecurity [11.0] web_export_view: add security group
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
[FIX] Initial resizing
[11.0][ADD] web_tree_resize_column: Resize columns in tree views
[FIX] web_widget_bokeh_chart
…_editor_dialog [ADD] web_widget_domain_editor_dialog: New module
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-11.0/web-11.0-web_widget_domain_editor_dialog Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_widget_domain_editor_dialog/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes example module instalable