Feature/login api #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2014 21:48
…d there is no edit interface (that will have to wait for better auth solutions, to a degree).
… and applications while adding SSO later. There are still huge gaping security holes here, but the eternally facing API should be stable.
Member
There was a problem hiding this comment.
did you mean to write groups = group_db.query(db.Group) and use groups in the next line?
Member
|
I'm not sure that I'm qualified or awake enough to approve this security-wise. However, it seems good enough to me common-sense-wise except for the things I commented on AND the fact that there are mixed tabs and spaces. Can we agree on a standard for spacing? I personally like no tabs (ever) with 4 spaces for Python. |
Member
Author
|
To be clear, this is not secure. It also isn't really intended to be; its a rough hack to get other people unblocked on being able to test auth based stuff. I'll let you know when I've pushed fixes for the other stuff you've brought up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Commit of Login API.