[youtube-thumbnails] Split thumbnail types and qualities #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every type (except for the special "0") is available in 5 quality
levels. Loop over them and show all of them on the page.
This hides the special "0" type image. This is an alias for default, but
only exposes a single quality level ("").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every type (except for the special "0") is available in 5 quality levels. Loop over them and show all of them on the page.
This hides the special "0" type image. This is an alias for default, but only exposes a single quality level ("").
Could also hardcode all the variants in one array, or first calculate a product of the two arrays, if you really do not want a nested
forEach. But I did not feel too bad to go the easy way for a single HTML file tool 😊