Skip to content

Conversation

@jcapriot
Copy link
Member

@jcapriot jcapriot commented Oct 8, 2025

Attempts at using ruff to lint and format code instead of flake8 + black

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.85%. Comparing base (e6058f1) to head (b21bc32).

Files with missing lines Patch % Lines
discretize/base/base_mesh.py 25.00% 3 Missing ⚠️
discretize/base/base_tensor_mesh.py 66.66% 1 Missing ⚠️
discretize/operators/inner_products.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          91       91           
  Lines       18856    18856           
  Branches     2123     2123           
=======================================
  Hits        16377    16377           
  Misses       1801     1801           
  Partials      678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@santisoler
Copy link
Member

💯 ! I would recommend checking out the Ruff config template that Scientific Python created: https://learn.scientific-python.org/development/guides/style/#ruff

It includes many additional rules that aren't checked by default. Some are too strict, but I found many of them quite useful.

@jcapriot
Copy link
Member Author

jcapriot commented Oct 8, 2025

Sounds good, I’ll add them in and check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants