Conversation
acasajus
reviewed
Mar 23, 2026
| ) | ||
| if coinbase_subscription and coinbase_subscription.is_active(): | ||
| # allow coinbase user to apply coupon 30d before their sub expires | ||
| if coinbase_subscription and coinbase_subscription.end_at > arrow.now().shift( |
Collaborator
There was a problem hiding this comment.
This condition is sub ends is later than 30d in the future. I guess it should be
Suggested change
| if coinbase_subscription and coinbase_subscription.end_at > arrow.now().shift( | |
| if coinbase_subscription and coinbase_subscription.end_at > arrow.now() and coinbase_subscription.end_at < now.shit(days=30) |
?
acasajus
approved these changes
Mar 24, 2026
acasajus
force-pushed
the
remove-coinbase-commerce
branch
from
b5a3e25 to
ca7e6f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.