Support symfony/finder:^7.1 alongside ~6.4.0 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donquixote
force-pushed
the
upgrade-symfony-finder
branch
6 times, most recently
from
e0e3e95 to
245efb2
Compare
donquixote
changed the title
donquixote
force-pushed
the
upgrade-symfony-finder
branch
from
245efb2 to
dcd20f9
Compare
donquixote
force-pushed
the
upgrade-symfony-finder
branch
from
dcd20f9 to
b79fe59
Compare
|
As you could have read here, we're gonna wait on the LTS Symfony 7.4. |
That's ok. |
Btw the main difference to the other PR is that this one still allows Symfony 6.x, and also runs the tests with both. |
|
Sure we can, but we choose not to. Don't get me wrong, but this project runs on virtually no-one and we have to pick our battles. |
|
This might ease your pain a bit: #66 Tagged v2.0.1 I hope you can drop your fork now. |
tvdijen
force-pushed
the
master
branch
5 times, most recently
from
9ab7bc6 to
3c65906
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that all the tests still pass with symfony/finder:^7.3. (and possibly lower, I did not try.)
We need this because we want to use simplesamlphp with Drupal 11, which requires symfony/*:^7.3.
We are ok to use a fork for the time being, but it would be much better to have this in upstream.
I am not sure how dependabot will like this.
Also, we could discuss if we want
^6.4.0|^7.3instead of~6.4.0|^7.3for symfony/finder. With the~it won't allow6.5.*if/when that comes out.