Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify service creation. Minor fixes #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dim
Copy link

@dim dim commented Dec 19, 2018

This PR avoids a few allocations by 'calculating' and memoizing names & paths in the constructor. It makes it simpler to create new/custom service abstractions.

@dim
Copy link
Author

dim commented Jan 14, 2019

@mcmoyer updated the PR, we may find a few more things as we progress, you may want to leave this one open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants