Skip to content

Fix checking for empty as opposed to None in object retrieval #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix checking for empty as opposed to None in object retrieval #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions simvue/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def get_runs(
f"but got '{type(json_response)}'"
)

if response_data := json_response.get("data"):
if (response_data := json_response.get("data")) is not None:
return response_data
elif output_format == "dataframe":
return to_dataframe(response.json())
Expand Down Expand Up @@ -877,7 +877,7 @@ def get_folders(
f"but got '{type(json_response)}'"
)

if not (data := json_response.get("data")):
if (data := json_response.get("data")) is None:
raise RuntimeError(
"Expected key 'data' in response during folder retrieval"
)
Expand Down
Loading