Skip to content

Add runtime error handling for Remote class to prevent heartbeat thread hang #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

kzscisoft
Copy link
Collaborator

A current issue is when the Remote class itself calls self._error and throws an exception, the heartbeat thread in Run continues. This fix ensures that these exceptions are then handled by Run via its own _error method which also terminates the heartbeat thread.

@kzscisoft kzscisoft added the bug Something isn't working label Jun 12, 2024
@kzscisoft kzscisoft self-assigned this Jun 12, 2024
@kzscisoft kzscisoft merged commit 8602d3d into dev Jun 12, 2024
2 of 3 checks passed
@kzscisoft kzscisoft deleted the hotfix/kill-all-on-exception branch June 12, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant