Skip to content

Added heartbeat timeout option to Run #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

kzscisoft
Copy link
Collaborator

@kzscisoft kzscisoft commented Aug 23, 2024

Adds the timeout argument to Run.init to specify the timeout period for the run where setting it to None disables the timeout.

Closes #494

@kzscisoft kzscisoft added the enhancement New feature or request label Aug 23, 2024
@kzscisoft kzscisoft added this to the API v1.1 milestone Aug 23, 2024
@james-panayis
Copy link
Collaborator

Would be nice if there was a test that tried the case where the timeout is set to None (and ideally then waited over 180 seconds to confirm that the run doesn't end up in the lost state).

@kzscisoft
Copy link
Collaborator Author

@james-panayis The issue with that is it will be a significant extension to CI execution time

@james-panayis
Copy link
Collaborator

@kzscisoft if you did the wait then sure, that'd increase the CI time. But just confirming that a run can actually be created with timeout None would not take especially long. I mostly would just like a test to confirm that the server will correctly interpret the request as an instruction to create a run.

@kzscisoft
Copy link
Collaborator Author

@james-panayis good point, the validation was not allowing None! So this test picked that up. Added it in now 🙂

@james-panayis james-panayis merged commit d4937ba into dev Sep 24, 2024
14 checks passed
@james-panayis james-panayis deleted the feature/heartbeat-enable branch September 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of option for no heartbeat when making server requests
2 participants