-
Notifications
You must be signed in to change notification settings - Fork 0
Added codecarbon tracking to Simvue Run #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c4b9ac3
to
1c02933
Compare
|
||
if self._emissions_tracker: | ||
with contextlib.suppress(Exception): | ||
self._emissions_tracker.stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add the final total carbon spent as metadata here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in _error, _exit etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely worth bearing in mind, maybe open an issue for future reference on this @wk9874
"codecarbon.emissions.delta": delta.emissions, | ||
"codecarbon.energy_consumed.delta": delta.energy_consumed, | ||
} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in the same way that Resources
has its own view in the Run Metrics page, we should add a Emissions
view and have these metrics stored in there (discuss with Andrew / raise an issue)
Use separate step counter for CC Allow setting of emission metric interval Use multiple CC trackers
The names of the metrics are possibly not compatible with the standard way "magic" metrics grouping works in the UI. By default the following will be grouped:
Does it make sense for deltas and totals to be displayed together? Update: with the special Emissions page the above is not really an issue anymore. |
Is it possible to suppress this message to stdout?
I also get this warning now when running the client:
|
When running this for 180 seconds I only get a single set of codecarbon metrics at the very end. Is this expected? |
I would need to see if it is possible to disable CC logging. As for the second that would be a fix to CC itself, my concern would be changing this would break it for older Python versions |
"Keep emissions data off by default" - Why? I would assume you want it on by default? |
@AbyAbraham21 Due to the fact that setup is required on the host machine for the CC metrics to be valid and correct we should make the user accountable for their recording as opposed to it being our responsibility that their setup is correct. @alahiff and I agreed having these off by default made sense. We will of course need to document enabling the feature. |
Uses Code Carbon to track emissions during a Simvue run, this can be disabled via the
config
method.