Offline Mode #674
Closed
Offline Mode #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kzscisoft
requested changes
Feb 3, 2025
| @@ -58,6 +70,9 @@ def get( | |||
| identifier for an alert | |||
| the alert itself as a class instance | |||
| """ | |||
| if offline: | |||
There was a problem hiding this comment.
Should this raise an Exception?
There was a problem hiding this comment.
I dont think so - we dont want it to stop executing, just to use the currently staged changes instead of fetching
…o wk9874/uploader
…o wk9874/uploader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Offline Mode
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu
Documentation PR: Issue on Docs repo.
📝 Summary
Added Offline mode sender
🔄 Changes
Various
✔️ Checklist