Skip to content

Fix abort test #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix abort test #755

merged 2 commits into from
Mar 7, 2025

Conversation

kzscisoft
Copy link
Collaborator

Fixes test_abort_run to actually test the run is terminated, also mocks os._exit so pytest doesnt abort itself.

@kzscisoft kzscisoft added enhancement New feature or request testing labels Mar 7, 2025
@kzscisoft kzscisoft requested a review from wk9874 March 7, 2025 12:50
@kzscisoft kzscisoft marked this pull request as ready for review March 7, 2025 12:51
@wk9874 wk9874 merged commit 00ede27 into dev Mar 7, 2025
12 checks passed
@kzscisoft kzscisoft deleted the hotfix/fix-abort-test branch March 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wk9874 wk9874 Awaiting requested review from wk9874

Assignees

@wk9874 wk9874

Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzscisoft @wk9874