Fix Ecoclient Units #778
Merged
Fix Ecoclient Units #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzscisoft
approved these changes
Apr 10, 2025
|
This all generally looks good - great to see the tests all passing and the default interval for getting new carbon intensity switched to 1 hour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EcoClient units are inconsistent and bugfixes
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu
📝 Summary
There were some inconsistencies in the units used by the ecoclient equations - have now changed this to consistently use kWh for energy, and kg for CO2 emissions
This actually now fixes a whole load of bugs, so many ive lost track of what's what...