Fix Visibility settings #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to have this working now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Visibility settings
Issue: #777, #779
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu
📝 Summary
Visibility settings in
run.initweren't applying correctly due to it not using the Visibility class🔍 Diagnosis
James spotted this while doing FDS sims for Interflam
🔄 Changes
Just changed visibility to change using the Visibility class instead of a dict update. Also fix
show_sharedto default to True inclient.get_runs). Added new visibility testsSetting user visibilities test is failing, but this is expected as it is a server side bug
✔️ Checklist