Skip to content

Fix Artifact sharing not working for shared runs #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

kzscisoft
Copy link
Collaborator

Fix Artifact sharing not working for shared runs

Issue: #788

Python Version(s) Tested: 3.13.3

Operating System(s): Windows 11

📝 Summary

Issue whereby downloading artifacts from tenant shared runs failed, the artifacts were not found.

🔍 Diagnosis

Used the low level API Artifact class to debug this and find an alternative solution.

🔄 Changes

Switched to using Artifact.from_name(...) instead of performing a general search and retrieving the first result.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft linked an issue May 20, 2025 that may be closed by this pull request
@kzscisoft kzscisoft requested a review from james-panayis May 20, 2025 21:10
@kzscisoft kzscisoft added bug Something isn't working python Pull requests that update python code in review This issue is resolved in a Pull Request which is being reviewed labels May 20, 2025
@james-panayis
Copy link
Collaborator

This does seem to fix the issue I was having - thanks! I'm a little uncomfortable about the failing tests, but if you're sure they're unrelated to this change then I think this is good to merge :)

@james-panayis james-panayis merged commit a5f8289 into dev Jun 9, 2025
15 of 17 checks passed
@kzscisoft kzscisoft deleted the 788-artifact-sharing-doesnt-work branch June 11, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review This issue is resolved in a Pull Request which is being reviewed python Pull requests that update python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact sharing doesn't work
2 participants