Skip to content

Need to set system details in reconnect() #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alahiff
Copy link
Collaborator

@alahiff alahiff commented May 21, 2025

This is a simple bug fix which ensures that system is populated when reconnect() is used. Currently such runs end up with system being completely empty.

@alahiff alahiff requested a review from kzscisoft May 21, 2025 15:13
@alahiff alahiff linked an issue May 21, 2025 that may be closed by this pull request
Copy link
Collaborator

@kzscisoft kzscisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just one line 😎

@kzscisoft kzscisoft merged commit d6ce062 into dev May 21, 2025
14 of 17 checks passed
@kzscisoft kzscisoft deleted the 787-when-reconnect-is-called-the-system-info-should-be-set branch May 21, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When reconnect() is called the system info should be set
2 participants