Skip to content

🐛 Fixed bug when threshold or alert range of zero specified #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Change log
## Unreleased
* Fixed bug where if the range or threshold of an alert is zero the alert type validation fails.
## [v2.1.1](https://github.com/simvue-io/client/releases/tag/v2.1.1) - 2025-04-25
* Changed from CO2 Signal to ElectricityMaps
* Fixed a number of bugs in how offline mode is handled with emissions
Expand Down
10 changes: 6 additions & 4 deletions simvue/api/objects/alert/fetch.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,17 +131,19 @@ def get(
_id,
UserAlert(_read_only=True, identifier=_id, _local=True, **_entry),
)
elif _entry["source"] == "metrics" and _entry.get("alert", {}).get(
"threshold"
elif (
_entry["source"] == "metrics"
and _entry.get("alert", {}).get("threshold") is not None
):
yield (
_id,
MetricsThresholdAlert(
_local=True, _read_only=True, identifier=_id, **_entry
),
)
elif _entry["source"] == "metrics" and _entry.get("alert", {}).get(
"range_low"
elif (
_entry["source"] == "metrics"
and _entry.get("alert", {}).get("range_low") is not None
):
yield (
_id,
Expand Down
Loading