Skip to content

Kzscisoft/781 uploads silently fail resulting in 0b files #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kzscisoft
Copy link
Collaborator

Fix 0B Uploads

Issue: #781

Python Version(s) Tested: 3.13
Operating System(s): Ubuntu 25.04

📝 Summary

Uploading files above a certain size led to 0B files being available to download.

🔍 Diagnosis

For some reason this is related to requests.post timeout even though I was led to believe this is the timeout for hearing from the server, not for request duration.

🔄 Changes

Add dynamic timeout which increases based on file size.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft linked an issue Jun 12, 2025 that may be closed by this pull request
@kzscisoft kzscisoft merged commit 372df7a into dev Jun 12, 2025
11 of 16 checks passed
@kzscisoft kzscisoft deleted the kzscisoft/781-uploads-silently-fail-resulting-in-0b-files branch June 12, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes artifact uploads silently fail, resulting in 0B files
1 participant