🐛 Ensure GridMetrics are sent with msgpack #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzscisoft
force-pushed
the
kzscisoft/862-send-non-scalar-metrics-values-using-msgpack
branch
2 times, most recently
from
95dd6e2 to
1050a13
Compare
alahiff
requested changes
Nov 5, 2025
Collaborator
alahiff
left a comment
alahiff
left a comment
There was a problem hiding this comment.
Everything is being sent as JSON, i.e. this pull request has no effect whatsoever.
Collaborator
|
I'm using |
kzscisoft
force-pushed
the
kzscisoft/862-send-non-scalar-metrics-values-using-msgpack
branch
from
1050a13 to
046e784
Compare
alahiff
approved these changes
Nov 6, 2025
Collaborator
alahiff
left a comment
alahiff
left a comment
There was a problem hiding this comment.
👏 Now looks good, data is being send as msgpack
kzscisoft
deleted the
kzscisoft/862-send-non-scalar-metrics-values-using-msgpack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that objects of type
GridMetricsare sent to the server viamsgpack.