Skip to content

Conversation

@NotHr
Copy link

@NotHr NotHr commented Jun 11, 2024

This is a new Pull Request as I have some doubts regarding the paths and this is a better version which uses the shell script provided by arch linux

A link to the script

@NotHr
Copy link
Author

NotHr commented Jun 12, 2024

So what should be the path and what changes should I make?

@sinanmohd
Copy link
Owner

the arch mirror should be rsynced to /var/lib/arch...*
and symlink it to /var/cache/mirror/archlinux using systemd.tmpfiles.rules(see /os/fscusat/modules/mirror/default.nix)

@sinanmohd sinanmohd changed the title feat: Add archlinux mirror fscusat/mirror/archlinux: init Jun 12, 2024
@NotHr
Copy link
Author

NotHr commented Jun 12, 2024

I updated the paths as requested. If any changes are required, please feel free to ping me.

cmd = pkgs.writeScript "rsync_cmd-${src}" ''
rsync -rlptH --safe-links --delete-delay --delay-updates \
--timeout=600 --contimeout=60 --no-motd \
${if pkgs.stty then "-h -v --progress" else "--quiet"} \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't make sense semantically, what are you trying to do here

${src} ${dest} ${lib.concatMapStrings (s: " '${s}'") extraArgs}
'';
in
pkgs.stdenv.mkDerivation {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a job for writeShellApplication


${rsync}
'';
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too much semantic hallucination in this pr :P, i can't review it in this state.
if you're new to nixos please go through nixos and nixpkgs manual and then you can update this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants