Skip to content

SpellResolved event added#342

Open
DragosIonita23 wants to merge 7 commits into
sindreslungaard:masterfrom
DragosIonita23:wonkerdrg/spell-resolved=event
Open

SpellResolved event added#342
DragosIonita23 wants to merge 7 commits into
sindreslungaard:masterfrom
DragosIonita23:wonkerdrg/spell-resolved=event

Conversation

@DragosIonita23
Copy link
Copy Markdown
Contributor

📝 Summary

SpellResolved event added

🎴 New Cards Added

🐞 Bugs Fixed

🔧 Other Changes

  • SpellResolved event added, in order to have better separation of game flow with respect to the TCG rule: separating the "spell cast" action from the "effect resolution" of that spell.
  • This will unblock Ice Vapor correct implementation in DM-09.
  • Normal spells that used fx.SpellCast were not affected
  • The handler inside spell.go file changed to emit the SpellResolved event inside the handler of SpellCast event.

✅ Checklist

Please confirm the following before submitting your PR:

  • I have read CONTRIBUTING.md
  • The changes has been tested locally
  • The PR does not contain an excessive amount of changes that could have been split up into multiple PRs

📸 Screenshots (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant