Fix Siren Concerto allowing itself to be selected (#392)#396
Open
Vladdudu12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #392. Siren Concerto's effect reads:
The second prompt allowed the player to select the Siren Concerto itself, even though by Duel Masters rules a spell being cast is on the stack and not actually in the hand. Selecting it caused Siren Concerto to be put into the mana zone instead of the graveyard, effectively refunding its cost and turning the spell into a free mana-zone card swap.
The fix changes the second
fx.Selecttofx.SelectFilterwith a predicate that excludes the casting card by ID:Cards retrieved from the mana zone in the first part of the effect remain selectable in the second part (this is correct per the rules — "then" implies sequential resolution, and the cost is still paid).
Note: while working on this I noticed Siren Concerto is also missing
fx.ShieldTriggerin itsc.Use(...)call despite the card text starting with "Shield trigger." Filed separately as #XXX to keep this PR focused.🎴 New Cards Added
🐞 Bugs Fixed
🔧 Other Changes
✅ Checklist
Please confirm the following before submitting your PR:
📸 Screenshots (if applicable)
Manually tested in a local match: