Skip to content

Add bits option - #53

Merged
sindresorhus merged 10 commits into
sindresorhus:masterfrom
prodialabs:master
Jul 26, 2019
Merged

Add bits option#53
sindresorhus merged 10 commits into
sindresorhus:masterfrom
prodialabs:master

Conversation

@montyanderson

Copy link
Copy Markdown

Switch units based on boolean 'bits' flag.

@sindresorhus

Copy link
Copy Markdown
Owner

What’s the use-case? Would be good to include that in the docs for the option.

@super3

super3 commented Jul 10, 2019

Copy link
Copy Markdown

@sindresorhus Download/upload speed is usually represented in bits/s vs bytes/s. We are using this for logging on YaCDN:

{ n: 14291272,
4|yacdn-5  |   url:
4|yacdn-5  |    'http://meowbaari.com/wp-content/uploads/2016/06/1464933654_cat_sleep.png',
4|yacdn-5  |   referer: undefined,
4|yacdn-5  |   size: '3.05 kB',
4|yacdn-5  |   time: '2101ms',
4|yacdn-5  |   *speed: '1.45 kbit/s'* }

@sindresorhus sindresorhus changed the title Add bits support Add bits option Jul 10, 2019
Comment thread index.d.ts Outdated
Comment thread index.d.ts Outdated
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread readme.md Outdated
@sindresorhus

Copy link
Copy Markdown
Owner

Download/upload speed is usually represented in bits/s vs bytes/s. We are using this for logging on YaCDN:

👍 Makes sense. Would be good to include the use-case about speed in the docs for the option.

@super3

super3 commented Jul 18, 2019

Copy link
Copy Markdown

@sindresorhus Are the changes satisfactory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants